[atable] Loading Options #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report for ./atable
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@crabinak Both of these look great. I added a timeout on an additional sample to see how it could render in the table. I've never used the |
@agritheory I've never used it before either, but it seems like it's meant for component trees that have multiple async components, and it allows managing loading states across all of them in a better way. |
Alchez
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agritheory Here are two options for the ATable loading we discussed utilizing a background gradient animation. I have one using the gradient and another using a bar that moves across the bottom. This is a Loading component that could be used in place of the ATable before the data loads. We can explore other options as well.
Setting this as a draft until we settle on a loading option as I have two similar components in there and unused ones would need to be cleaned up before merging.